Skip to content

Add stubs for symbol#1047

Merged
gvanrossum merged 2 commits into
python:masterfrom
JelleZijlstra:symbol
Mar 23, 2017
Merged

Add stubs for symbol#1047
gvanrossum merged 2 commits into
python:masterfrom
JelleZijlstra:symbol

Conversation

@JelleZijlstra

Copy link
Copy Markdown
Member

No description provided.

@ambv

ambv commented Mar 21, 2017

Copy link
Copy Markdown
Contributor

Why not use the 3.6 variable annotation syntax?

@JelleZijlstra

Copy link
Copy Markdown
Member Author

Mypy still doesn't support that in typeshed I believe. Or was that fixed?

@ambv

ambv commented Mar 21, 2017

Copy link
Copy Markdown
Contributor

It's fine after python/mypy#3000 got merged.

@JelleZijlstra

Copy link
Copy Markdown
Member Author

Do we know for sure that pycharm is also OK? (Pytype is covered by Travis.)

@ambv

ambv commented Mar 21, 2017

Copy link
Copy Markdown
Contributor

@vlasovskikh, does PyCharm support variable annotations in stubs for all Python versions? Mypy and pytype do.

@ilevkivskyi

Copy link
Copy Markdown
Member

annassign = ... # type: int looks quite ironically :-)

@vlasovskikh

Copy link
Copy Markdown
Member

@ambv Recent versions of PyCharm use the Python 3.6 syntax for Python stubs.

@gvanrossum gvanrossum merged commit fa104ea into python:master Mar 23, 2017
@JelleZijlstra JelleZijlstra deleted the symbol branch March 23, 2017 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants